Console View
|
Tags: Architectures Distributions Performance Style Tests |
|
| Architectures | Distributions | Performance | Style | Tests | ||||||||||||||||||||||||||
|
|
|
|
|
|
||||||||||||||||||||||||||
|
DHE
git@dehacked.net |
|
|
|
|
|
|||||||||||||||||||||||||
|
Install suitable arc_summary.py script Use the "standard" version of python (as determined by /usr/bin/python) to decide which of the two versions to install, and install only that one. Previously we installed both regardless of the system version which could lead to dependency problems in package managers. Fixes #7651 Signed-off-by: DHE <git@dehacked.net> Pull-request: #7813 part 1/1 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
loli10K
ezomori.nozomu@gmail.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
Stack overflow when destroying deeply nested clones Destroy operations on deeply nested chains of clones can overflow the stack: Depth Size Location (221 entries) ----- ---- -------- 0) 15664 48 mutex_lock+0x5/0x30 1) 15616 8 mutex_lock+0x5/0x30 ... 26) 13576 72 dsl_dataset_remove_clones_key.isra.4+0x124/0x1e0 [zfs] 27) 13504 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 28) 13432 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] ... 185) 2128 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 186) 2056 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 187) 1984 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 188) 1912 136 dsl_destroy_snapshot_sync_impl+0x4e0/0x1090 [zfs] 189) 1776 16 dsl_destroy_snapshot_check+0x0/0x90 [zfs] ... 218) 304 128 kthread+0xdf/0x100 219) 176 48 ret_from_fork+0x22/0x40 220) 128 128 kthread+0x0/0x100 Fix this issue by converting dsl_dataset_remove_clones_key() from recursive to iterative. Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Pull-request: #7810 part 1/1 |
||||||||||||||||||||||||||||||
|
loli10K
ezomori.nozomu@gmail.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
Stack overflow when destroying deeply nested clones Destroy operations on deeply nested chains of clones can overflow the stack: Depth Size Location (221 entries) ----- ---- -------- 0) 15664 48 mutex_lock+0x5/0x30 1) 15616 8 mutex_lock+0x5/0x30 ... 26) 13576 72 dsl_dataset_remove_clones_key.isra.4+0x124/0x1e0 [zfs] 27) 13504 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 28) 13432 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] ... 185) 2128 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 186) 2056 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 187) 1984 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 188) 1912 136 dsl_destroy_snapshot_sync_impl+0x4e0/0x1090 [zfs] 189) 1776 16 dsl_destroy_snapshot_check+0x0/0x90 [zfs] ... 218) 304 128 kthread+0xdf/0x100 219) 176 48 ret_from_fork+0x22/0x40 220) 128 128 kthread+0x0/0x100 Fix this issue by converting dsl_dataset_remove_clones_key() from recursive to iterative. Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Pull-request: #7810 part 1/1 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
loli10K
ezomori.nozomu@gmail.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
Stack overflow when destroying deeply nested clones Destroy operations on deeply nested chains of clones can overflow the stack: Depth Size Location (221 entries) ----- ---- -------- 0) 15664 48 mutex_lock+0x5/0x30 1) 15616 8 mutex_lock+0x5/0x30 ... 26) 13576 72 dsl_dataset_remove_clones_key.isra.4+0x124/0x1e0 [zfs] 27) 13504 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 28) 13432 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] ... 185) 2128 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 186) 2056 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 187) 1984 72 dsl_dataset_remove_clones_key.isra.4+0x18a/0x1e0 [zfs] 188) 1912 136 dsl_destroy_snapshot_sync_impl+0x4e0/0x1090 [zfs] 189) 1776 16 dsl_destroy_snapshot_check+0x0/0x90 [zfs] ... 218) 304 128 kthread+0xdf/0x100 219) 176 48 ret_from_fork+0x22/0x40 220) 128 128 kthread+0x0/0x100 Fix this issue by converting dsl_dataset_remove_clones_key() from recursive to iterative. Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Pull-request: #7810 part 1/1 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
bunder2015
omfgbunder@gmail.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
ZTS: events path cleanup Removing hardcoded paths in events.cfg Reviewed-by: Giuseppe Di Natale <guss80@gmail.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: bunder2015 <omfgbunder@gmail.com> Closes #7805 |
||||||||||||||||||||||||||||||
|
bunder2015
omfgbunder@gmail.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
ZTS: largest_pool_001 path cleanup Removing hardcoded paths in largest_pool_001 Reviewed-by: Giuseppe Di Natale <guss80@gmail.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: bunder2015 <omfgbunder@gmail.com> Closes #7804 |
||||||||||||||||||||||||||||||
|
bunder2015
omfgbunder@gmail.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
ZTS: privilege group path cleanup Removing hardcoded paths in privilege group tests Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: bunder2015 <omfgbunder@gmail.com> Closes #7803 |
||||||||||||||||||||||||||||||
|
Brian Behlendorf
behlendorf1@llnl.gov |
|
|
|
|
|
|||||||||||||||||||||||||
|
ZTS: Fix import_cache_device_replaced Allow the 'zpool replace' to run slowly without overwhelming the vdev queues by setting zfs_scan_vdev_limit=128k. This limits the number of concurrent slow IOs which need to be handled. The net effect is the test case runs approximately 3x faster putting it well under the 10 minute per-test time limit. Rename import_cache* test cases to imprt_cachefile*. Originally these were renamed due to a maximum tar name limit, this limit was removed by commit 1dfde3d9b. Replaced instances of /var/tmp in zpool_import.cfg with $TEST_BASE_DIR. Reviewed-by: bunder2015 <omfgbunder@gmail.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #7765 Closes #7802 |
||||||||||||||||||||||||||||||
|
LOLi
loli10K@users.noreply.github.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
'zfs holds' scripted mode is not documented This change simply documents the existing "scripted mode" option in both command help and man page. Reviewed-by: Giuseppe Di Natale <guss80@gmail.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes #7798 |
||||||||||||||||||||||||||||||
|
LOLi
loli10K@users.noreply.github.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
Fix arcstat.py handling of unsupported options This change allows the arcstat.py script to handle unsupported options gracefully and print both error and usage messages when one such option is provided. Reviewed-by: Giuseppe Di Natale <guss80@gmail.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: loli10K <ezomori.nozomu@gmail.com> Closes #7799 |
||||||||||||||||||||||||||||||
|
bunder2015
omfgbunder@gmail.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
ZTS: events path cleanup Removing hardcoded paths in events.cfg Signed-off-by: bunder2015 <omfgbunder@gmail.com> Pull-request: #7805 part 1/1 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
bunder2015
omfgbunder@gmail.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
ZTS: largest_pool_001 path cleanup Removing hardcoded paths in largest_pool_001 Signed-off-by: bunder2015 <omfgbunder@gmail.com> Pull-request: #7804 part 1/1 |
||||||||||||||||||||||||||||||
|
bunder2015
omfgbunder@gmail.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
ZTS: privilege group path cleanup Removing hardcoded paths in privilege group tests Signed-off-by: bunder2015 <omfgbunder@gmail.com> Pull-request: #7803 part 1/1 |
||||||||||||||||||||||||||||||
|
Brian Behlendorf
behlendorf1@llnl.gov |
|
|
|
|
|
|||||||||||||||||||||||||
|
ZTS: Fix import_cache_device_replaced Allow the 'zpool replace' to run slowly without overwhelming the vdev queues by setting zfs_scan_vdev_limit=128k. This limits the number of concurrent slow IOs which need to be handled. The net effect is the test case runs approximately 3x faster putting it well under the 10 minute per-test time limit. Rename import_cache* test cases to imprt_cachefile*. Originally these were renamed due to a maximum tar name limit, this limit was removed by commit 1dfde3d9b. Replaced instances of /var/tmp in zpool_import.cfg with $TEST_BASE_DIR. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #7765 Pull-request: #7802 part 1/1 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Brian Behlendorf
behlendorf1@llnl.gov |
|
|
|
|
|
|||||||||||||||||||||||||
|
ZTS: Fix import_cache_device_replaced Allow the 'zpool replace' to run slowly without overwhelming the vdev queues by setting zfs_scan_vdev_limit=128k. This limits the number of concurrent slow IOs which need to be handled. The net effect is the test case runs approximately 3x faster putting it well under the 10 minute per-test time limit. Rename import_cache* test cases to imprt_cachefile*. Originally these were renamed due to a maximum tar name limit, this limit was removed by commit 1dfde3d9b. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #7765 Pull-request: #7802 part 1/1 |
||||||||||||||||||||||||||||||
|
Olaf Faaland
faaland1@llnl.gov |
|
|
|
|
|
|||||||||||||||||||||||||
|
Skip import activity test in more zdb code paths Since zdb opens the pools read-only, it cannot damage the pool in the event the pool is already imported either on the same host or on another one. If the pool vdev structure is changing while zdb is importing the pool, it may cause zdb to crash. However this is unlikely, and in any case it's a user space process and can simply be run again. For this reason, zdb should disable the multihost activity test on import that is normally run. This commit fixes a few zdb code paths where that had been overlooked. It also adds tests to ensure that several common use cases handle this properly in the future. Signed-off-by: Olaf Faaland <faaland1@llnl.gov> Pull-request: #7801 part 1/1 |
||||||||||||||||||||||||||||||
|
Olaf Faaland
faaland1@llnl.gov |
|
|
|
|
|
|||||||||||||||||||||||||
|
Skip import activity test in zdb Pull-request: #7801 part 2/2 |
||||||||||||||||||||||||||||||
|
Olaf Faaland
faaland1@llnl.gov |
|
|
|
|
|
|||||||||||||||||||||||||
|
Add tests to verify zdb works while multihost is enabled Pull-request: #7801 part 1/2 |
||||||||||||||||||||||||||||||
|
Don Brady
don.brady@delphix.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
Address recent feedback and rebase to master Signed-off-by: Don Brady <don.brady@delphix.com> Pull-request: #7780 part 6/6 |
||||||||||||||||||||||||||||||
|
Don Brady
don.brady@delphix.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
fix test_release() in libzfs tests Signed-off-by: Don Brady <don.brady@delphix.com> Pull-request: #7780 part 5/6 |
||||||||||||||||||||||||||||||
|
Don Brady
don.brady@delphix.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
Fix pyzfs test failures Signed-off-by: Don Brady <don.brady@delphix.com> Pull-request: #7780 part 4/6 |
||||||||||||||||||||||||||||||
|
Don Brady
don.brady@delphix.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
Fixed input req for zfs_ioc_get_bookmarks Signed-off-by: Don Brady <don.brady@delphix.com> Pull-request: #7780 part 3/6 |
||||||||||||||||||||||||||||||
|
Don Brady
don.brady@delphix.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
Fix build issues and addressed review feedback Signed-off-by: Don Brady <don.brady@delphix.com> Pull-request: #7780 part 2/6 |
||||||||||||||||||||||||||||||
|
Don Brady
don.brady@delphix.com |
|
|
|
|
|
|||||||||||||||||||||||||
|
Add basic zfs ioc input nvpair validation Signed-off-by: Don Brady <don.brady@delphix.com> Pull-request: #7780 part 1/6 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Definition check working now. Pull-request: #7728 part 22/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Add request-key.conf documentation. Pull-request: #7728 part 21/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Update zfs_init() to return error code to accomodate failure of zpl_xattr_init(). Pull-request: #7728 part 20/22 |
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Negate return value from zfs_ functions. Pull-request: #7728 part 19/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Update to latest illumos acl.h Pull-request: #7728 part 18/22 |
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Add nfs4acl to man page and cli help. Pull-request: #7728 part 17/22 |
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Deal with kernel API changes for user_key_payload(). Pull-request: #7728 part 16/22 |
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Hmm, this isn't working right; punt for now. Pull-request: #7728 part 15/22 |
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Fix style nits. Pull-request: #7728 part 14/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Switch to kmem_alloc() / kmem_free(). Pull-request: #7728 part 13/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Oops, cleaned this up a little too much 8-/. Pull-request: #7728 part 12/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Remove question and fix style nits. Pull-request: #7728 part 11/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Move includes. Pull-request: #7728 part 10/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Unconditionally enable per review. Pull-request: #7728 part 9/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Don't need this. Pull-request: #7728 part 8/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
Paul B. Henson
henson@acm.org |
|
|
|
|
|
|||||||||||||||||||||||||
|
Move init/cleanup to appropriate spot; but what about init failure? Pull-request: #7728 part 7/22 |
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||